Skip to content

Add formula function BAHTTEXT support #2187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Now-Shimmer
Copy link
Contributor

PR Details

Add formula function BAHTTEXT support

Description

Add formula function BAHTTEXT support

Related Issue

Add formula function BAHTTEXT support

Motivation and Context

Add formula function BAHTTEXT support

How Has This Been Tested

Add unit test for my changes.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@peng peng added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 11, 2025
@Now-Shimmer
Copy link
Contributor Author

Hi @peng, I fixed code review issue, please take a review. Thanks!

Copy link

codecov bot commented Aug 13, 2025

Codecov Report

❌ Patch coverage is 0% with 93 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.94%. Comparing base (b372bd3) to head (07093cb).

Files with missing lines Patch % Lines
calc.go 0.00% 93 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2187      +/-   ##
==========================================
- Coverage   99.24%   98.94%   -0.31%     
==========================================
  Files          32       32              
  Lines       30571    30664      +93     
==========================================
  Hits        30340    30340              
- Misses        153      246      +93     
  Partials       78       78              
Flag Coverage Δ
unittests 98.94% <0.00%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants